Re: [cc65] [PATCH 3/3] Generate libsrc/apple2enh/extra if necessary

From: Greg King <greg.king41verizon.net>
Date: 2012-08-24 14:33:05
From: "Spiro Trikaliotis"; on Wednesday, August 22, 2012; at 6:52 AM -0400
>
> * On Wed, Aug 22, 2012 at 11:54:31AM +0200 Ullrich von Bassewitz wrote:
>>
>> On Wed, Aug 22, 2012 at 11:20:07AM +0200, Spiro Trikaliotis wrote:
>>
>> > Even using SVN would not help here for me. The Debian build system
>> > will
>> > remove empty dirs. if told to do a "make clean".
>>
>> OK. Might I dare to ask for the specific advantages of that approach?
>> Just being curious, as ever. Please note that I'm well prepared to
>> accept
>> that there is no good reason whatsoever. :-)
>
> I would say that there is no good reason here, either. At least, I do not
> know one.

They might have had these rationalizations:
1. If a person erased all of the files in a directory, then that person
probably meant to erase the directory also -- but, forgot.
2. Empty directories waste space -- on disks, in repositories, and in
directory tree listings.

>
> However, as I have had this "problem" more than once, I learned never to
> rely on directories being there if they are empty. That's why I wanted
> to add the "mkdir" into the build scripts. For me, it's a way of being
> careful with the build system; handling the case that it does not do
> what one might expect. I even did that when I was working with SVN.
>
> But, as I said, I also can add this to the Debian makefile; so, it's not
> a big issue. That's also the reason why I did not just commit it into
> your SVN; why I sent it to this ML; so we can discuss it, and I can
> see if you like it or not. Now, I know your result. ;-)

Your patch needs one small improvement:  "extradir" must be an order-only
prerequisite.

extra/%.o: ../apple2/extra/%.s | extradir

(Otherwise, it _always_ would rebuild the extra object files, because
extradir
is a PHONY target.)

----------------------------------------------------------------------
To unsubscribe from the list send mail to majordomo@musoftware.de with
the string "unsubscribe cc65" in the body(!) of the mail.
Received on Fri Aug 24 15:35:38 2012

This archive was generated by hypermail 2.1.8 : 2012-08-24 15:35:41 CEST