Re: [cc65] A Bad Change to "tgi.h"

From: Oliver Schmidt <ol.sc1web.de>
Date: 2011-04-23 20:37:54
Hi Greg,

> I am unhappy with the April 20th patch to <tgi.h>.

Sorry for commiting without first explaining !

> I believe that TGI's black and white colors should be defined globally.
> They should be 0 and 1 on _all_ platforms -- they shouldn't be
> target-specific.  On targets where the hardware uses different numbers,
> the graphics drivers should remap the numbers.

As Uz already explained the cc65-way-of-doing-things is to push as
much effort as reasonable from runtime to designtime. A nice example
are the macros for switching between 40 and 80 column display:

apple2enh:
#define VIDEOMODE_40x24 0x0011
#define VIDEOMODE_80x24 0x0012
#define VIDEOMODE_40COL VIDEOMODE_40x24
#define VIDEOMODE_80COL VIDEOMODE_80x24

c128:
#define VIDEOMODE_40x25         0x00
#define VIDEOMODE_80x25         0x80
#define VIDEOMODE_40COL         VIDEOMODE_40x25
#define VIDEOMODE_80COL         VIDEOMODE_80x25

Regards,
Oliver
----------------------------------------------------------------------
To unsubscribe from the list send mail to majordomo@musoftware.de with
the string "unsubscribe cc65" in the body(!) of the mail.
Received on Sat Apr 23 20:38:07 2011

This archive was generated by hypermail 2.1.8 : 2011-04-23 20:38:10 CEST