Re: [cc65] Please critique this makefile

On 2010-04-24, at 16:21, Oliver Schmidt <ol.sc@web.de> wrote:

> Hi,
>
>> My current "universal" Makefile is at:
>>
>> http://zennon.internetdsl.pl/Makefile
>
> Some remarks:
>
> 1.
>
> ifeq ($(MYVAR),)
>
> is actually equivalent to
>
> ifndef MYVAR
>

I thought so too, but have rewritten it to ifeq only after finding  
that ifndef doesn't work as expected :-(

>
> 2.
>
> Your new target 'love' should be added to the dependency list  
> of .PHONY
>
> .PHONY: all clean love

Yes, you are right of course! :-) I was checking something and forgot  
about it.


> 3.
>
> basename is not the list of utilities a Makefile is supposed to  
> depend on:
> http://www.gnu.org/software/make/manual/make.html#Utilities-in-Makefiles
>
> So your line

Actually it wasn't really mine but…

> PROGRAM := $(shell basename $(CURDIR))
> turns the Makefile much less portable. […]

… I very much prefer yours below. Exactly for the reasons you  
described!

> This line is way simpler (and by the way faster)
> PROGRAM := $(notdir $(CURDIR))

I shall check it once back at computer.

-- 
SD!

----------------------------------------------------------------------
To unsubscribe from the list send mail to majordomo@musoftware.de with
the string "unsubscribe cc65" in the body(!) of the mail.