Re: [cc65] c64 get_ostype patch

Hi!

On Tue, Feb 09, 2010 at 06:12:40PM -0500, Greg King wrote:
> 1. The function is called get_  os  type().
> 2. Three of its constants _are_ spelled:
>    C64_OS_US, C64_OS_PET64, and C64_OS_SX64.

I've seen that. 

> They are why I think that the DTV constant should be spelled C64_OS_DTV.

You forgot to tell, that there are also constants that don't have _OS_
in their names: C64_EU_NEW, C64_EU_OLD. So C64_DTV fits nicely :-)

The real problem is that get_ostype doesn't actually do what it should do
according to its name. It does in some situations detect the operating system
(= kernal version or whatever). In other cases (for example with the DTV), it
detects different hardware. 

One argument in your favour is that having _OS_ in the constant names makes
them more orthogonal and tells the user that these are actually return codes
of get_ostype. But this would mean that the two mentioned above would have to
be renamed (eventually breaking old code), and other platforms checked as
well.

Regards


        Uz


-- 
Ullrich von Bassewitz                                  uz@musoftware.de
----------------------------------------------------------------------
To unsubscribe from the list send mail to majordomo@musoftware.de with
the string "unsubscribe cc65" in the body(!) of the mail.