[cc65] Patch format (was: weird range error)

Hello,

just a quick question regarding the patches you send out:

* On Thu, Apr 14, 2005 at 10:37:05PM +0200 Ullrich von Bassewitz wrote:

> Index: studyexpr.c
> ===================================================================
> RCS file: /usr/local/cvsroot/uz/c64/cc65/src/ca65/studyexpr.c,v
> retrieving revision 1.6
> diff -c -b -r1.6 studyexpr.c
> *** studyexpr.c	19 Dec 2004 22:15:43 -0000	1.6
> --- studyexpr.c	14 Apr 2005 20:34:57 -0000
> ***************
> *** 619,625 ****
>       StudyExprInternal (Expr->Right, &Right);
> 
>       /* Check if we can handle the operation */
> !     if (ED_IsValid (D) || ED_IsValid (&Right)) {
> 
>           /* Add both */
>           ED_Add (D, &Right);
> --- 619,625 ----
>       StudyExprInternal (Expr->Right, &Right);
> 
>       /* Check if we can handle the operation */
> !     if (ED_IsValid (D) && ED_IsValid (&Right)) {
> 
>           /* Add both */
>           ED_Add (D, &Right);

[...]

Wouldn't it be nicer, smaller and better human-readable to use the
unified diff format? In this case, the above would look something like

> diff -c -u -b -r1.6 studyexpr.c
> *** studyexpr.c	19 Dec 2004 22:15:43 -0000	1.6
> --- studyexpr.c	14 Apr 2005 20:34:57 -0000
> ***************
> *** 619,625 ****
>       StudyExprInternal (Expr->Right, &Right);
> 
>       /* Check if we can handle the operation */
> -     if (ED_IsValid (D) || ED_IsValid (&Right)) {
> +     if (ED_IsValid (D) && ED_IsValid (&Right)) {
> 
>           /* Add both */
>           ED_Add (D, &Right);

At least I myself find this much better readable. YMMV.

Do you have any specific reasons to use the above format?

Regards,
   Spiro.

-- 
Spiro R. Trikaliotis
http://www.trikaliotis.net/
----------------------------------------------------------------------
To unsubscribe from the list send mail to majordomo@musoftware.de with
the string "unsubscribe cc65" in the body(!) of the mail.