From: Ullrich von Bassewitz (uz_at_musoftware.de)
Date: 2002-12-04 12:23:02
On Wed, Dec 04, 2002 at 11:12:14AM +0100, MagerValp wrote:
> SJ> I added case CH_EOL: to your menu.c file where you have case 10:
> SJ> and case 13:
>
> Uz, maybe you could add #define CH_EOL 13 to cbm.h?
While I think that the key definition itself is useful, I don't like the "EOL"
here, because it is non obvious from the name that this key is in fact the
enter key. CH_EOL is of cource correct, since it is also the line separator
used in files, but the CH_... definitions are normally used when scanning the
keyboard, and here "EOL" does not really mean anything. If it had a name like
CH_ENTER, I would probably have noticed long before that having such a
definition is a good idea (on the other side, if MagerValp had used '\n' and
'\r' instead of 10 and 13, it would have worked on the Atari without any
changes:-)
Christian, can we rename this key to CH_ENTER (or something similar)? We can
keep the CH_EOL in the atari.h header file for some time to be compatible with
old code, but mark it as obsolete. I will the add CH_ENTER to the include
files of the other platforms as well.
Regards
Uz
--
Ullrich von Bassewitz uz_at_musoftware.de
----------------------------------------------------------------------
To unsubscribe from the list send mail to majordomo_at_musoftware.de with
the string "unsubscribe cc65" in the body(!) of the mail.
This archive was generated by hypermail 2.1.3 : 2002-12-04 12:23:05 CET